GH-44713: [Python] Add support for Decimal32 and Decimal64 types - #44882
Conversation
|
|
|
Please add the concrete classes for the scalars to the list under the Scalars heading in And after you add the Thanks! |
|
Current battles (so I remember them Monday!): I'm missing some member definition for the use-facing type classes: import pyarrow as pa
pa.decimal128(2, 0).precision
#> 2
pa.decimal256(2, 0).precision
#> 2
pa.decimal32(2, 0).precision
#> AttributeError: 'pyarrow.lib.Decimal32Type' object has no attribute 'precision'There's no cast implemented from "float" to "decimal32/64", which at least some of the tests depend on: |
8ff213e to
65222c7
Compare
There was a problem hiding this comment.
You'll need to add Decimal32Array, Decimal64Array to line 220 and Decimal32Scalar, Decimal64Scalar to line 229
There was a problem hiding this comment.
should update to between 1 and 18
|
Ok! I think this just needs #45014 . |
<!-- Thanks for opening a pull request! If this is your first pull request you can find detailed information on how to contribute here: * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request) * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html) If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project. Then could you also rename the pull request title in the following format? GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY} or MINOR: [${COMPONENT}] ${SUMMARY} --> ### Rationale for this change Furthering the support for Decimal32/Decimal64 among Acero and casting functionality. This is also necessary for #44882 to add support for Decimal32/64 to PyArrow <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ### What changes are included in this PR? Adding kernels for casting to and from Decimal32/Decimal64 between numeric, floating point, string and other decimal types. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ### Are these changes tested? Yes, unit tests are added accordingly. <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> * GitHub Issue: #43956
756bd80 to
e4ff26e
Compare
raulcd
left a comment
There was a problem hiding this comment.
Are tests and documentation finished? Just wondering if the description of the PR has to be updated or is there something missing that is expected to be followed up on a subsequent PR
|
@raulcd Sorry, I should have updated that. I've updated documentation and tests accordingly already! |
|
@github-actions crossbow submit -g python |
pitrou
left a comment
There was a problem hiding this comment.
LGTM, I just wonder if the hypothesis tests pass
|
Revision: e4ff26e Submitted crossbow builds: ursacomputing/crossbow @ actions-c539869415 |
|
The CI failures are unrelated. You might want to wait for @jorisvandenbossche 's review, but you can merge as well. |
|
Thank you for taking a look! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2fcf8b3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
Arrow C++ and the Arrow specification now support 32-bit and 64-bit decimal types...pyarrow should too!
What changes are included in this PR?
Added type, array, and scalar bindings.
Are these changes tested?
Yes!
Are there any user-facing changes?
Yes!